[copr] master: when we fail to complete a build but don't cause a traceback - then we need to check if the pkgs failed to build (f202e55)

skvidal at fedorahosted.org skvidal at fedorahosted.org
Wed Jan 9 20:01:17 UTC 2013


Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : master

>---------------------------------------------------------------

commit f202e55fd1339c5b641e198053d2ae4c737d0258
Author: Seth Vidal <skvidal at fedoraproject.org>
Date:   Wed Jan 9 14:59:04 2013 -0500

    when we fail to complete a build but don't cause a traceback - then
    we need to check if the pkgs failed to build


>---------------------------------------------------------------

 backend/dispatcher.py |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/backend/dispatcher.py b/backend/dispatcher.py
index 9b0399d..a0115fc 100644
--- a/backend/dispatcher.py
+++ b/backend/dispatcher.py
@@ -288,9 +288,15 @@ class Worker(multiprocessing.Process):
                     # record and break
                     self.callback.log('%s - %s' % (ip, e))
                     status = 0 # failure
+                else:
+                    # we can't really trace back if we just fail normally
+                    # check if any pkgs didn't build
+                    if mr.failed: 
+                        status = 0
                 self.callback.log('Finished build: builder=%r timeout=%r destdir=%r chroot=%r repos=%r' % (ip, job.timeout, job.destdir, chroot, str(job.repos)))
                 
             job.ended_on = time.time()
+            
             job.status = status
             self.return_results(job)
             self.callback.log('worker finished build: %s' % ip)



More information about the copr-devel mailing list