[copr] skvidal-backend: move to shutil.move not os.rename b/c of mount boundaries (452080a)

skvidal at fedoraproject.org skvidal at fedoraproject.org
Fri Nov 30 16:38:09 UTC 2012


Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : skvidal-backend

>---------------------------------------------------------------

commit 452080a9c849b46663760d0a7c67383f25121a94
Author: Seth Vidal <skvidal at fedoraproject.org>
Date:   Fri Nov 30 11:36:00 2012 -0500

    move to shutil.move not os.rename b/c of mount boundaries


>---------------------------------------------------------------

 backend/dispatcher.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/backend/dispatcher.py b/backend/dispatcher.py
index 8b47c70..dac7498 100644
--- a/backend/dispatcher.py
+++ b/backend/dispatcher.py
@@ -3,6 +3,7 @@
 
 import os
 import sys
+import shutil
 import multiprocessing
 import time
 import Queue
@@ -101,6 +102,7 @@ class Worker(multiprocessing.Process):
         self.callback.log('creating worker: %s' % ip)
 
     def spawn_instance(self):
+        """call the spawn playbook to startup/provision a building instance"""
         self.callback.log('spawning instance begin')
         
         stats = callbacks.AggregateStats()
@@ -124,6 +126,7 @@ class Worker(multiprocessing.Process):
         return None
 
     def terminate_instance(self):
+        """call the terminate playbook to destroy the building instance"""
         self.callback.log('terminate instance begin')
         
         stats = callbacks.AggregateStats()
@@ -154,9 +157,10 @@ class Worker(multiprocessing.Process):
         return jobdata
 
     def return_results(self, job):
+        """write out a completed json file to the results dir and submit the results to the frontend"""
         self.callback.log('%s status %s. Took %s seconds' % (job.build_id, job.status, job.ended_on - job.started_on))
         jobfilename = os.path.basename(job.jobfile)
-        os.rename(job.jobfile, job.destdir + '/' + jobfilename)
+        shutil.move(job.jobfile, job.destdir + '/' + jobfilename)
         #FIXME - this should either return job status/results 
         # into a queue or it should submit results directly to the frontend
         



More information about the copr-devel mailing list