[copr] bkabrda-workspace: Build is waiting if it didn't start AND didn't end (7825ad2)

bkabrda at fedoraproject.org bkabrda at fedoraproject.org
Wed Nov 28 10:20:34 UTC 2012


Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : bkabrda-workspace

>---------------------------------------------------------------

commit 7825ad28315207d97d65c95cd92813a8c9d5fc8f
Author: Bohuslav Kabrda <bkabrda at redhat.com>
Date:   Wed Nov 28 11:15:35 2012 +0100

    Build is waiting if it didn't start AND didn't end


>---------------------------------------------------------------

 coprs_frontend/coprs/logic/builds_logic.py |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/coprs_frontend/coprs/logic/builds_logic.py b/coprs_frontend/coprs/logic/builds_logic.py
index 4c87c0a..41575ee 100644
--- a/coprs_frontend/coprs/logic/builds_logic.py
+++ b/coprs_frontend/coprs/logic/builds_logic.py
@@ -35,12 +35,15 @@ class BuildsLogic(object):
 
     @classmethod
     def get_waiting_builds(cls, user):
+        # return builds that aren't both started and finished (if build start submission
+        # fails, we still want to mark the build as non-waiting, if it ended)
         # this has very different goal then get_multiple, so implement it alone
         query = models.Build.query.join(models.Build.copr).\
                                    join(models.User).\
                                    options(db.contains_eager(models.Build.copr)).\
                                    options(db.contains_eager('copr.owner')).\
                                    filter(models.Build.started_on == None).\
+                                   filter(models.Build.ended_on == None).\
                                    filter(models.Build.canceled != True).\
                                    order_by(models.Build.submitted_on.asc())
         return query



More information about the copr-devel mailing list