[copr] bkabrda-workspace: Reverse the logic for build state a bit for cases when the build start submission may get lost (ae1fd8f)

bkabrda at fedorahosted.org bkabrda at fedorahosted.org
Tue Nov 20 07:40:19 UTC 2012


Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : bkabrda-workspace

>---------------------------------------------------------------

commit ae1fd8f999b4ee68f90ed3eaa4f5d70456399ed3
Author: Bohuslav Kabrda <bkabrda at redhat.com>
Date:   Tue Nov 20 08:40:08 2012 +0100

    Reverse the logic for build state a bit for cases when the build start submission may get lost


>---------------------------------------------------------------

 wsgi/coprs/models.py |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/wsgi/coprs/models.py b/wsgi/coprs/models.py
index e58109f..b36315e 100644
--- a/wsgi/coprs/models.py
+++ b/wsgi/coprs/models.py
@@ -146,16 +146,15 @@ class Build(db.Model, Serializer):
 
     @property
     def state(self):
+        if self.status == 1:
+            return 'succeeded'
+        elif self.status == 0:
+            return 'failed'
         if self.canceled:
             return 'canceled'
-        if not self.started_on:
-            return 'pending'
-        if not self.ended_on:
+        if not self.ended_on and self.started_on:
             return 'running'
-        if self.status == 1:
-            return 'succeeded'
-
-        return 'failed'
+        return 'pending'
 
     @property
     def cancelable(self):



More information about the copr-devel mailing list