[copr] bkabrda-workspace: Keep commits in views (ffa1793)

bkabrda at fedorahosted.org bkabrda at fedorahosted.org
Mon Nov 19 09:04:46 UTC 2012


Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : bkabrda-workspace

>---------------------------------------------------------------

commit ffa17939b2a414227889435ef2d4b6882383d544
Author: Bohuslav Kabrda <bkabrda at redhat.com>
Date:   Mon Nov 19 10:04:40 2012 +0100

    Keep commits in views


>---------------------------------------------------------------

 wsgi/coprs/logic/coprs_logic.py      |    2 --
 wsgi/coprs/views/coprs_ns/general.py |    2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/wsgi/coprs/logic/coprs_logic.py b/wsgi/coprs/logic/coprs_logic.py
index f4ee668..e39347c 100644
--- a/wsgi/coprs/logic/coprs_logic.py
+++ b/wsgi/coprs/logic/coprs_logic.py
@@ -49,14 +49,12 @@ class CoprsLogic(object):
         if check_for_duplicates and cls.exists_for_current_user(user, copr.name):
             raise exceptions.DuplicateCoprNameException
         db.session.add(copr)
-        db.session.commit()
 
     @classmethod
     def update(cls, user, copr, check_for_duplicates = True):
         if check_for_duplicates and cls.exists_for_current_user(user, copr.name):
             raise exceptions.DuplicateCoprNameException
         db.session.add(copr)
-        db.session.commit()
 
     @classmethod
     def exists_for_current_user(cls, user, coprname):
diff --git a/wsgi/coprs/views/coprs_ns/general.py b/wsgi/coprs/views/coprs_ns/general.py
index 4ed669e..c4a0fbb 100644
--- a/wsgi/coprs/views/coprs_ns/general.py
+++ b/wsgi/coprs/views/coprs_ns/general.py
@@ -62,6 +62,7 @@ def copr_new():
                            repos = form.repos.data.replace('\n', ' '),
                            owner = flask.g.user)
         coprs_logic.CoprsLogic.new(flask.g.user, copr, check_for_duplicates = False) # form validation checks for duplicates
+        db.session.commit()
 
         flask.flash('New entry was successfully posted')
         return flask.redirect(flask.url_for('coprs_ns.coprs_show'))
@@ -117,6 +118,7 @@ def copr_update(username, coprname):
         copr.repos = form.repos.data.replace('\n', ' ')
 
         coprs_logic.CoprsLogic.update(flask.g.user, copr, check_for_duplicates = False) # form validation checks for duplicates
+        db.session.commit()
         flask.flash('Copr was updated successfully.')
         return flask.redirect(flask.url_for('coprs_ns.copr_detail', username = username, coprname = form.name.data))
     else:



More information about the copr-devel mailing list