UDisks LVM addon ready to play with

Marius Vollmer marius.vollmer at redhat.com
Fri Dec 20 06:31:17 UTC 2013


Stef Walter <stefw at redhat.com> writes:

> So after some work on udisks-lvm it's now ready to play with.

Great!

> LVM name encoding
>
> The Name property now contains the possibly encoded name, and the
> DisplayName the possibly decoded one.
>
> That said I don't think we should be encoding the LVM volume group and
> logical volume names passed in over the DBus API. This goes against the
> Cockpit ethos (and likely OpenLMI too) of exposing what's on the
> system rather than hiding it away under some layer. Encoding the   names
> makes it awkward to create a volume group via the API and then use it
> from the command line.

Yeah.  Since we expose LVM2 directly, we might as well expose its naming
limitations.

> Poll()
>
> Do we really need to have Poll()? Can we just poll as needed, especially
> now that we quit when no more clients are around?

Hmm, that would be nice.  I am not sure whether udisksd-lvm does indeed
quit often enough.  We would rely on the clients to exit nicely, too...


More information about the cockpit-devel mailing list