<div dir="ltr">Never mind, you answer this in your commit:<div><br></div><div><div>commit 39461d11f47be0bc31ff7a39c2e2981af220a942</div><div>Author: Jörgen Maas <<a href="mailto:jorgen.maas@gmail.com">jorgen.maas@gmail.com</a>></div><div>Date: Sun Sep 14 09:24:45 2014 +0200</div><div><br></div><div> Module manage_in_tftpd.py now returns 'in_tftpd' from what().</div><div><br></div><div> Besides this being a bit more consistent this also fixes some</div><div> warnings in 'cobbler check'.</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 15, 2014 at 12:50 PM, Greg Chavez <span dir="ltr"><<a href="mailto:greg.chavez@gmail.com" target="_blank">greg.chavez@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Won't that break older Centos/RHEL/Fedora where, like RHEL 5, where tftpd.what returns "<span style="font-family:arial,sans-serif;font-size:12.7272720336914px">in_tftpd"</span>? Or are they no longer supported?<div><br></div><div>I was hoping to make this my first pull request for this project! Oh well, next time maybe. Thanks for helping, Jörgen.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>--Greg</div></font></span><div><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Sep 14, 2014 at 3:28 AM, Jörgen Maas <span dir="ltr"><<a href="mailto:jorgen.maas@gmail.com" target="_blank">jorgen.maas@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi, <br><br></div>Thanks for reporting this issue. <br>I've got the following fix into master and release26<br><br>diff --git a/cobbler/modules/manage_in_tftpd.py b/cobbler/modules/manage_in_tftpd.py<br>index b53672c..578fd3f 100644<br>--- a/cobbler/modules/manage_in_tftpd.py<br>+++ b/cobbler/modules/manage_in_tftpd.py<br>@@ -40,7 +40,7 @@ def register():<br> class InTftpdManager:<br> <br> def what(self):<br>- return "tftpd"<br>+ return "in_tftpd"<br> <br> def __init__(self, config, logger):<br> """<br><br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Sat, Sep 13, 2014 at 8:14 PM, Greg Chavez <span dir="ltr"><<a href="mailto:greg.chavez@gmail.com" target="_blank">greg.chavez@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div><br></div><div>Cloned Cobbler 2.6.5 onto CentOS 6.5, installed as an rpm.</div><div><br></div><div>Among the usual cobbler check warnings from a new install, I was getting this:</div><div><br></div><div>1 : Unmanaged tftpd server 'tftpd'</div><div><br></div><div>And this was despite having the system tftp-server package installed and enabled in xinetd. I poked around and found these lines in python2.6/site-packages/cobbler/action_check.py (72-83):</div><div><br></div><div><div> mode = self.config.api.get_sync().tftpd.what()</div><div> self.check_tftpd_dir(status)</div></div><div><div> if mode == "in_tftpd":</div><div> self.check_tftpd_bin(status)</div><div> self.check_tftpd_conf(status)</div><div> elif mode == "tftpd_py":</div><div> self.check_ctftpd_bin(status)</div><div> self.check_ctftpd_conf(status)</div><div> else :</div><div> status.append("Unmanaged tftpd server '%s'" % mode)</div></div><div><br></div><div>Simply changing in_tftpd to tftpd, cleared the check warning. But before I make a pull request, I wanted to ask if perhaps the issue is not this code but tftpd.what. I am not a python programmer, so of I can't find/xargs/grep it out, I likely can't figure out what's going on.</div><div><br></div><div>What's the right way to fix this?</div><div><br></div><div>Thanks.</div><span><font color="#888888"><div><br></div>-- <br>\*..+.-<br>--Greg Chavez<br>+//..;};
</font></span></div>
<br></div></div>_______________________________________________<br><br></blockquote></div></div></blockquote></div></div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>\*..+.-<br>--Greg Chavez<br>+//..;};
</div>