gfs2-utils: master - gfs2-utils configure: Fix exit with failure condition

Andrew Price andyp at fedoraproject.org
Mon Oct 13 15:56:29 UTC 2014


Gitweb:        http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=456b884ac4ce75559b90a4d4fb197db813f7c327
Commit:        456b884ac4ce75559b90a4d4fb197db813f7c327
Parent:        0ae4f708ee2fc2c8c246444a87d7cc1f14e96ae1
Author:        Andrew Price <anprice at redhat.com>
AuthorDate:    Fri Oct 10 20:53:48 2014 +0100
Committer:     Andrew Price <anprice at redhat.com>
CommitterDate: Fri Oct 10 20:53:48 2014 +0100

gfs2-utils configure: Fix exit with failure condition

When gcov is disabled, the test at the end of the configure script would
cause the script to exit with status 1 despite succeeding. Restructure
the test to make sure its exit status is consumed in an if statement.

Signed-off-by: Andrew Price <anprice at redhat.com>
---
 configure.ac |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index a978e52..2269aba 100644
--- a/configure.ac
+++ b/configure.ac
@@ -234,5 +234,9 @@ AC_CONFIG_FILES([Makefile
 
 AC_OUTPUT
 
-test x"$have_check" = "xyes" || AC_MSG_NOTICE([package 'check' not found; unit tests will not be built])
-test x"${enable_gcov}" = "xyes" && AC_MSG_NOTICE([code coverage enabled; optimization will be disabled])
+if test x"${have_check}" != "xyes"; then
+	AC_MSG_NOTICE([package 'check' not found; unit tests will not be built])
+fi
+if test x"${enable_gcov}" = "xyes"; then
+	AC_MSG_NOTICE([code coverage enabled; optimization will be disabled])
+fi


More information about the cluster-commits mailing list