cluster: RHEL6 - fsck.gfs2: Log when unrecoverable data block errors are encountered

Bob Peterson rpeterso at fedoraproject.org
Tue May 21 12:23:52 UTC 2013


Gitweb:        http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=6839b4acd056e8267b4fb1872e3d0783f49a4ef6
Commit:        6839b4acd056e8267b4fb1872e3d0783f49a4ef6
Parent:        1db69f5d398482c2e121404c4376f6fb75031a70
Author:        Bob Peterson <rpeterso at redhat.com>
AuthorDate:    Tue Apr 2 12:59:16 2013 -0700
Committer:     Bob Peterson <rpeterso at redhat.com>
CommitterDate: Fri May 17 15:26:30 2013 -0500

fsck.gfs2: Log when unrecoverable data block errors are encountered

This patch adds a log message whenever unrecoverable data block errors
are found. Otherwise the output doesn't say why it stopped processing
data, and which block had the problem.

rhbz#902920
---
 gfs2/fsck/metawalk.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index 9b6c391..1cd377e 100644
--- a/gfs2/fsck/metawalk.c
+++ b/gfs2/fsck/metawalk.c
@@ -1320,10 +1320,15 @@ static int check_data(struct gfs2_inode *ip, struct metawalk_fxns *pass,
 		   pass1. Therefore the individual check_data functions
 		   should do a range check. */
 		rc = pass->check_data(ip, metablock, block, pass->private);
+		if (!error && rc) {
+			error = rc;
+			log_info(_("\nUnrecoverable data block error %d on "
+				   "block %llu (0x%llx).\n"), rc,
+				 (unsigned long long)block,
+				 (unsigned long long)block);
+		}
 		if (rc < 0)
 			return rc;
-		if (!error && rc)
-			error = rc;
 		(*blks_checked)++;
 	}
 	return error;


More information about the cluster-commits mailing list