cluster: RHEL510 - rgmanager: Fix potential unlocked memory access

Ryan McCabe rmccabe at fedoraproject.org
Mon Jul 22 17:01:56 UTC 2013


Gitweb:        http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=9deeb287a75677409180478beb7b95f7be9d35f8
Commit:        9deeb287a75677409180478beb7b95f7be9d35f8
Parent:        6dbd73bff5c609a9b7aa57c8b15c7194554355df
Author:        Ryan McCabe <rmccabe at redhat.com>
AuthorDate:    Tue Feb 26 10:57:47 2013 -0500
Committer:     Ryan McCabe <rmccabe at redhat.com>
CommitterDate: Mon Jul 22 12:58:21 2013 -0400

rgmanager: Fix potential unlocked memory access

Fix a potential unlocked access of the resource list.

Related: rhbz#968322

Signed-off-by: Ryan McCabe <rmccabe at redhat.com>
---
 rgmanager/src/daemons/groups.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c
index 20ed2e1..13237da 100644
--- a/rgmanager/src/daemons/groups.c
+++ b/rgmanager/src/daemons/groups.c
@@ -1842,7 +1842,9 @@ init_resource_groups(int reconfigure, int do_init, int new_config_version)
 
 		do_condstops();
 
+		pthread_rwlock_rdlock(&resource_lock);
 		copy_incarnations(&_resources, &reslist);
+		pthread_rwlock_unlock(&resource_lock);
 	}
 
 	/* Swap in the new configuration */


More information about the cluster-commits mailing list