cluster: RHEL510 - fsck.gfs2: pass1c counts percentage backward

Bob Peterson rpeterso at fedoraproject.org
Fri Apr 5 13:46:18 UTC 2013


Gitweb:        http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=0c93cdb7378757e954d635e114e37a62a888b17e
Commit:        0c93cdb7378757e954d635e114e37a62a888b17e
Parent:        68922b8444c39c78a79b9f62062e60adfaa5f1ea
Author:        Bob Peterson <rpeterso at redhat.com>
AuthorDate:    Fri Jan 6 14:20:26 2012 -0600
Committer:     Bob Peterson <rpeterso at redhat.com>
CommitterDate: Fri Apr 5 06:25:00 2013 -0700

fsck.gfs2: pass1c counts percentage backward

In testing I noticed that pass1c, which checks all extended
attributes, counted percent-complete backwards.  It's better to
count forward because disk block seeks will be more efficient.
This patch changes the special_list functions of block_list to
add items as "prev" so that they're processed in block order.

rhbz#877150
---
 gfs2/libgfs2/block_list.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gfs2/libgfs2/block_list.c b/gfs2/libgfs2/block_list.c
index a7e28f3..06384a1 100644
--- a/gfs2/libgfs2/block_list.c
+++ b/gfs2/libgfs2/block_list.c
@@ -54,7 +54,7 @@ void gfs2_special_add(struct special_blocks *blocklist, uint64_t block)
 	if (b) {
 		memset(b, 0, sizeof(*b));
 		b->block = block;
-		osi_list_add(&b->list, &blocklist->list);
+		osi_list_add_prev(&b->list, &blocklist->list);
 	}
 }
 


More information about the cluster-commits mailing list