cluster: RHEL59 - rgmanager: Fix a possible NULL pointer dereference

Ryan McCabe rmccabe at fedoraproject.org
Tue Jul 10 19:52:38 UTC 2012


Gitweb:        http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=49c6289cd6c394f6b18d7f61f0177ed886643f14
Commit:        49c6289cd6c394f6b18d7f61f0177ed886643f14
Parent:        4a3415a2056b8b09ab272edefc0de8950b84f393
Author:        Ryan McCabe <rmccabe at redhat.com>
AuthorDate:    Thu Jun 28 15:50:37 2012 -0400
Committer:     Ryan McCabe <rmccabe at redhat.com>
CommitterDate: Tue Jul 10 15:52:14 2012 -0400

rgmanager: Fix a possible NULL pointer dereference

Fix a NULL pointer dereference that could happen when cman_get_node_count()
returns 0 with errno set to EINTR.

Possibly resolves rhbz#820632

Acked-by: Fabio M. Di Nitto <fdinitto at redhat.com>
Signed-off-by: Ryan McCabe <rmccabe at redhat.com>
---
 rgmanager/src/clulib/members.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/rgmanager/src/clulib/members.c b/rgmanager/src/clulib/members.c
index f705297..72f4529 100644
--- a/rgmanager/src/clulib/members.c
+++ b/rgmanager/src/clulib/members.c
@@ -367,8 +367,10 @@ get_member_list(cman_handle_t h)
 
 	do {	
 		++tries;
-		if (nodes)
+		if (nodes) {
 			free(nodes);
+			nodes = NULL;
+		}
 
 		c = cman_get_node_count(h);
 		if (c <= 0) {


More information about the cluster-commits mailing list