cluster: RHEL57 - rgmanager: Resolve rare deadlock

Lon Hohberger lon at fedoraproject.org
Tue Jan 10 21:36:27 UTC 2012


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=7cb765d530c34dc39cb0e6ed36641f3feafd4c6d
Commit:        7cb765d530c34dc39cb0e6ed36641f3feafd4c6d
Parent:        0e53e6655e2dbf0432f2b0d4af9f2df07c25727a
Author:        Lon Hohberger <lhh at redhat.com>
AuthorDate:    Tue Sep 6 15:42:41 2011 -0400
Committer:     Lon Hohberger <lhh at redhat.com>
CommitterDate: Tue Jan 10 16:35:46 2012 -0500

rgmanager: Resolve rare deadlock

In very rare cases, it was possible to fill up a pipe used for
IPC between threads during reconfiguration, causing a deadlock.
This patch resolves the issue.

Resolves: rhbz#759542

Signed-off-by: Lon Hohberger <lhh at redhat.com>
---
 rgmanager/src/daemons/groups.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c
index b546421..1e93e03 100644
--- a/rgmanager/src/daemons/groups.c
+++ b/rgmanager/src/daemons/groups.c
@@ -1737,8 +1737,6 @@ init_resource_groups(int reconfigure, int do_init, int new_config_version)
 		free(val);
 	}
 
-	/* Wait for any pending requests */
-	rg_wait_threads();
 	/* Block operations that would break during configuration
 	   changes */
 	rg_clear_initialized(FL_CONFIG);


More information about the cluster-commits mailing list