gfs2-utils: master - gfs2_edit: Fix resource leak in print_block_details()

Andrew Price andyp at fedoraproject.org
Fri Jan 6 15:27:43 UTC 2012


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=1be8f8542ab8f7154104403e0a15886c7023c214
Commit:        1be8f8542ab8f7154104403e0a15886c7023c214
Parent:        fc401d5799f0e9ee81fcdad029de1b3cafbebfae
Author:        Andrew Price <anprice at redhat.com>
AuthorDate:    Fri Jan 6 15:10:08 2012 +0000
Committer:     Andrew Price <anprice at redhat.com>
CommitterDate: Fri Jan 6 15:10:08 2012 +0000

gfs2_edit: Fix resource leak in print_block_details()

Spotted by coverity: Variable "more_indir" going out of scope leaks the
storage it points to.

Signed-off-by: Andrew Price <anprice at redhat.com>
---
 gfs2/edit/extended.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gfs2/edit/extended.c b/gfs2/edit/extended.c
index 7c0ced5..1066e1b 100644
--- a/gfs2/edit/extended.c
+++ b/gfs2/edit/extended.c
@@ -396,6 +396,7 @@ static void print_block_details(struct iinfo *ind, int level, int cur_height,
 	if (!tmpbuf) {
 		fprintf(stderr, "Out of memory in function "
 			"display_indirect\n");
+		free(more_indir);
 		return;
 	}
 	while (thisblk) {


More information about the cluster-commits mailing list