gfs2-utils: master - gfs2_edit: Remove unused j_inode from find_journal_block()

Andrew Price andyp at fedoraproject.org
Fri Jan 6 15:27:35 UTC 2012


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=fef703bd67ef15e77d8aed68f9a1874c786ab134
Commit:        fef703bd67ef15e77d8aed68f9a1874c786ab134
Parent:        2e46fea08029eb744bf0964c3aa32da83aa3065a
Author:        Andrew Price <anprice at redhat.com>
AuthorDate:    Fri Jan 6 13:14:50 2012 +0000
Committer:     Andrew Price <anprice at redhat.com>
CommitterDate: Fri Jan 6 13:14:50 2012 +0000

gfs2_edit: Remove unused j_inode from find_journal_block()

Spotted by coverity: Pointer "j_inode" returned by "inode_get(&sbd,
j_bh)" is never used

Signed-off-by: Andrew Price <anprice at redhat.com>
---
 gfs2/edit/hexedit.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/gfs2/edit/hexedit.c b/gfs2/edit/hexedit.c
index 7a17c04..1deb374 100644
--- a/gfs2/edit/hexedit.c
+++ b/gfs2/edit/hexedit.c
@@ -1493,7 +1493,6 @@ static uint64_t find_journal_block(const char *journal, uint64_t *j_size)
 	int amtread;
 	struct gfs2_buffer_head *jindex_bh, *j_bh;
 	char jbuf[sbd.bsize];
-	struct gfs2_inode *j_inode = NULL;
 
 	journal_num = atoi(journal + 7);
 	/* Figure out the block of the jindex file */
@@ -1527,7 +1526,6 @@ static uint64_t find_journal_block(const char *journal, uint64_t *j_size)
 
 		jblock = indirect->ii[0].dirent[journal_num + 2].block;
 		j_bh = bread(&sbd, jblock);
-		j_inode = inode_get(&sbd, j_bh);
 		gfs2_dinode_in(&jdi, j_bh);/* parse dinode to struct */
 		*j_size = jdi.di_size;
 		brelse(j_bh);


More information about the cluster-commits mailing list