gfs2-utils: master - gfs2_edit: Fix possible uninitialized access

Andrew Price andyp at fedoraproject.org
Fri Jan 6 15:27:32 UTC 2012


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=ddf8ac5616093598271b9cbadc07253ca44dd45b
Commit:        ddf8ac5616093598271b9cbadc07253ca44dd45b
Parent:        d8bb8e2a981287ea7bc5cf7a73753b6e809edb72
Author:        Andrew Price <anprice at redhat.com>
AuthorDate:    Thu Jan 5 16:24:35 2012 +0000
Committer:     Andrew Price <anprice at redhat.com>
CommitterDate: Thu Jan 5 16:24:35 2012 +0000

gfs2_edit: Fix possible uninitialized access

Spotted by coverity: Using uninitialized value "ch".

Signed-off-by: Andrew Price <anprice at redhat.com>
---
 gfs2/edit/hexedit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gfs2/edit/hexedit.c b/gfs2/edit/hexedit.c
index fcab625..72ee7d2 100644
--- a/gfs2/edit/hexedit.c
+++ b/gfs2/edit/hexedit.c
@@ -2232,7 +2232,7 @@ static void process_field(const char *field, const char *nstr)
 /* ------------------------------------------------------------------------ */
 static void interactive_mode(void)
 {
-	int ch, Quit;
+	int ch = 0, Quit;
 
 	if ((wind = initscr()) == NULL) {
 		fprintf(stderr, "Error: unable to initialize screen.");


More information about the cluster-commits mailing list