cluster: RHEL6 - rgmanager: Resolve rare deadlock

Lon Hohberger lon at fedoraproject.org
Wed Feb 22 14:46:45 UTC 2012


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=8168796b4f1d4e7435b2212a18d4cffbd86e1fa4
Commit:        8168796b4f1d4e7435b2212a18d4cffbd86e1fa4
Parent:        3624e3e0deed9eb3e6b4325a9ac3249dcb0a110a
Author:        Lon Hohberger <lhh at redhat.com>
AuthorDate:    Tue Sep 6 15:42:41 2011 -0400
Committer:     Lon Hohberger <lhh at redhat.com>
CommitterDate: Tue Feb 21 13:26:33 2012 -0500

rgmanager: Resolve rare deadlock

In very rare cases, it was possible to fill up a pipe used for
IPC between threads during reconfiguration, causing a deadlock.
This patch resolves the issue.

Resolves: rhbz#635152

Signed-off-by: Lon Hohberger <lhh at redhat.com>
---
 rgmanager/src/daemons/groups.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c
index e9413cd..ee0fc81 100644
--- a/rgmanager/src/daemons/groups.c
+++ b/rgmanager/src/daemons/groups.c
@@ -1683,8 +1683,6 @@ init_resource_groups(int reconfigure, int do_init)
 		free(val);
 	}
 
-	/* Wait for any pending requests */
-	rg_wait_threads();
 	/* Block operations that would break during configuration
 	   changes */
 	rg_clear_initialized(FL_CONFIG);


More information about the cluster-commits mailing list