gfs2-utils: master - Fix clang --analyze warning.

Andrew Price andyp at fedoraproject.org
Tue Dec 18 10:44:48 UTC 2012


Gitweb:        http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=699d35a6c313c4b2c6090a94939188e373a48168
Commit:        699d35a6c313c4b2c6090a94939188e373a48168
Parent:        f98cba4c9517fa593171542abf7d76859bd6d700
Author:        Sitsofe Wheeler <sitsofe at yahoo.com>
AuthorDate:    Mon Dec 17 14:43:13 2012 +0000
Committer:     Andrew Price <anprice at redhat.com>
CommitterDate: Tue Dec 18 10:43:46 2012 +0000

Fix clang --analyze warning.

- Return before a possible NULL pointer dereference.
---
 gfs2/libgfs2/fs_bits.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gfs2/libgfs2/fs_bits.c b/gfs2/libgfs2/fs_bits.c
index 94a612b..e4b5505 100644
--- a/gfs2/libgfs2/fs_bits.c
+++ b/gfs2/libgfs2/fs_bits.c
@@ -149,6 +149,8 @@ int gfs2_set_bitmap(struct gfs2_sbd *sdp, uint64_t blkno, int state)
 			break;
 	}
 
+	if (bits == NULL)
+		return -1;
 	byte = (unsigned char *)(rgd->bh[buf]->b_data + bits->bi_offset) +
 		(rgrp_block/GFS2_NBBY - bits->bi_start);
 	bit = (rgrp_block % GFS2_NBBY) * GFS2_BIT_SIZE;


More information about the cluster-commits mailing list