cluster: STABLE32 - rgmanager: Fix potential double-free

Fabio M. Di Nitto fabbione at fedoraproject.org
Wed Aug 15 13:07:20 UTC 2012


Gitweb:        http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=46b260230d6ea532db98d659ccf8e204010afa07
Commit:        46b260230d6ea532db98d659ccf8e204010afa07
Parent:        3388fbd37581b447e8f2e69fae012092fa532ce4
Author:        Lon Hohberger <lhh at redhat.com>
AuthorDate:    Fri Sep 16 14:24:11 2011 -0400
Committer:     Fabio M. Di Nitto <fdinitto at redhat.com>
CommitterDate: Wed Aug 15 11:04:38 2012 +0200

rgmanager: Fix potential double-free

Signed-off-by: Lon Hohberger <lhh at redhat.com>
---
 rgmanager/src/daemons/rg_state.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/rgmanager/src/daemons/rg_state.c b/rgmanager/src/daemons/rg_state.c
index 5d16af4..463e12f 100644
--- a/rgmanager/src/daemons/rg_state.c
+++ b/rgmanager/src/daemons/rg_state.c
@@ -314,6 +314,7 @@ get_rg_state(const char *name, rg_state_t *svcblk)
 	if (ret != VFR_OK || datalen == 0) {
 		if (data)
 			free(data);
+		data = NULL;
 
 		ret = init_rg(name, svcblk);
 		if (ret != VFR_OK) {
@@ -326,6 +327,7 @@ get_rg_state(const char *name, rg_state_t *svcblk)
 		if (ret != VFR_OK) {
 			if (data)
 				free(data);
+			data = NULL;
 			free_member_list(membership);
 			printf("Couldn't reread rg %s! (%d)\n", name, ret);
 			return RG_EFAIL;


More information about the cluster-commits mailing list