cluster: RHEL6 - fsck.gfs2: segfault in pass1b

Bob Peterson rpeterso at fedoraproject.org
Fri Jun 3 12:53:31 UTC 2011


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=e9a69100bf11c054baeb659ba9760c713d0162cb
Commit:        e9a69100bf11c054baeb659ba9760c713d0162cb
Parent:        18c47dede44df18b6ebad1e1a20756e3ba498596
Author:        Bob Peterson <rpeterso at redhat.com>
AuthorDate:    Fri Jun 3 07:17:25 2011 -0500
Committer:     Bob Peterson <rpeterso at redhat.com>
CommitterDate: Fri Jun 3 07:17:25 2011 -0500

fsck.gfs2: segfault in pass1b

The problem occurred when there were duplicate block
references in a dinode but all references in the duplicate
list are eventually deleted due to other corruption.
The fix is an additional check whether the list is empty.

rhbz#679080
---
 gfs2/fsck/pass1b.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gfs2/fsck/pass1b.c b/gfs2/fsck/pass1b.c
index 4d97879..7f79783 100644
--- a/gfs2/fsck/pass1b.c
+++ b/gfs2/fsck/pass1b.c
@@ -542,7 +542,7 @@ static int handle_dup_blk(struct gfs2_sbd *sbp, struct duptree *b)
 		last_reference = clear_a_reference(sbp, b, &b->ref_inode_list,
 						   &dh, 0);
 
-	if (last_reference) {
+	if (last_reference && !osi_list_empty(&b->ref_inode_list)) {
 		uint8_t q;
 
 		/* If we're down to a single reference (and not all references


More information about the cluster-commits mailing list