fence-agents: master - fence_drac5: Incorrect output of 'list' operation on Drac 5

Marek Grác marx at fedoraproject.org
Fri Jul 8 08:12:31 UTC 2011


Gitweb:        http://git.fedorahosted.org/git/fence-agents.git?p=fence-agents.git;a=commitdiff;h=5a518f3cb382c2711bd027916164c7ac45ab3e3e
Commit:        5a518f3cb382c2711bd027916164c7ac45ab3e3e
Parent:        dc07a1c1bab35664697b78f4eb9c50df3359b84a
Author:        Marek 'marx' Grac <mgrac at redhat.com>
AuthorDate:    Fri Jul 8 09:54:42 2011 +0200
Committer:     Marek 'marx' Grac <mgrac at redhat.com>
CommitterDate: Fri Jul 8 09:54:42 2011 +0200

fence_drac5: Incorrect output of 'list' operation on Drac 5

Previously (due to other bug) fence agents operation 'list' was not
working properly. After fixing that issue, drac5 returned empty line
instead of N/A as an output for 'list'. This happends because fencing
library does not have support for situations when for one fence agents
there are fence devices that supports / not supports 'list' option.

Resolves: rhbz#718194 (regression introduced by previous patch)
---
 fence/agents/drac5/fence_drac5.py |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fence/agents/drac5/fence_drac5.py b/fence/agents/drac5/fence_drac5.py
index 53676ee..5e72e42 100644
--- a/fence/agents/drac5/fence_drac5.py
+++ b/fence/agents/drac5/fence_drac5.py
@@ -72,6 +72,10 @@ def get_list_devices(conn, options):
 					outlets[list_re.search(line).group(1)] = ("", list_re.search(line).group(2))
 		elif options["model"] == "DRAC 5":
 			## DRAC 5 can be used only for one computer
+			## standard fence library can't handle correctly situation
+			## when some fence devices supported by fence agent
+			## works with 'list' and other should returns 'N/A'
+			print "N/A"
 			pass
 	except pexpect.EOF:
 		fail(EC_CONNECTION_LOST)


More information about the cluster-commits mailing list