cluster: STABLE31 - qdisk: Informational syslog message indicating label overrides device

Lon Hohberger lon at fedoraproject.org
Tue Feb 1 16:55:32 UTC 2011


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=8cb4fbc7e7ffc16cfffcc1a14a3253830a77f69d
Commit:        8cb4fbc7e7ffc16cfffcc1a14a3253830a77f69d
Parent:        5822073b63d1b83af623bb3c72dccc97f4eb2e27
Author:        Jeremy Miller <csf1dsh at ups.com>
AuthorDate:    Tue Feb 1 11:52:54 2011 -0500
Committer:     Lon Hohberger <lhh at redhat.com>
CommitterDate: Tue Feb 1 11:52:54 2011 -0500

qdisk: Informational syslog message indicating label overrides device

When user specifies both quorum label and quorum device (ccs allows this), the
user isn't notified that the label will override the device when searching
through disks for the quorum partition.  This can mislead the user into
thinking that qdiskd will in fact use the quorum device they specified.

This can have serious consequences when the user intends qdiskd to use a
specified a multipath device such as "/dev/mapper/qdisk", but in actuality
qdiskd will just use the first device it finds with matching user specified
label (for example "/dev/dm-17").  According to Red Hat documentation, when
using multipath, one should always use /dev/mapper/xxx devices to ensure
proper path failover, rather than /dev/dm-xx or /dev/mpath/xxx devices.

Signed-off-by: Lon Hohberger <lhh at redhat.com>
Reviewed-by: Fabio M. Di Nitto <fdinitto at redhat.com>
---
 cman/qdisk/main.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/cman/qdisk/main.c b/cman/qdisk/main.c
index 617a705..ebdb018 100644
--- a/cman/qdisk/main.c
+++ b/cman/qdisk/main.c
@@ -1746,6 +1746,11 @@ get_static_config_data(qd_ctx *ctx, int ccsfd)
 	snprintf(query, sizeof(query), "/cluster/quorumd/@label");
 	if (ccs_get(ccsfd, query, &val) == 0) {
 		ctx->qc_label = val;
+		/* courtesy info message */
+		if (ctx->qc_device)
+			logt_print(LOG_INFO, "Quorum Label (%s) will be used to "
+				   "locate quorum partition, overriding Quorum Device\n",
+				   ctx->qc_label);
 	}
 
 	if (!ctx->qc_device && !ctx->qc_label) {


More information about the cluster-commits mailing list