gfs2-utils: master - fsck.gfs2: get rid of triple negative logic

Bob Peterson rpeterso at fedoraproject.org
Tue Aug 30 20:25:29 UTC 2011


Gitweb:        http://git.fedorahosted.org/git/gfs2-utils.git?p=gfs2-utils.git;a=commitdiff;h=3997b83236a388c22d37be67c0b015bbf3d3a5c5
Commit:        3997b83236a388c22d37be67c0b015bbf3d3a5c5
Parent:        536823ad0bc31840a79a02bdd8482cba248b5a51
Author:        Bob Peterson <rpeterso at redhat.com>
AuthorDate:    Mon Aug 8 14:44:46 2011 -0500
Committer:     Bob Peterson <rpeterso at redhat.com>
CommitterDate: Mon Aug 29 12:53:02 2011 -0500

fsck.gfs2: get rid of triple negative logic

This patch changes the logic of the code from being triple-negative
to single-negative so it won't twist your brain into knots.

rhbz#675723
---
 gfs2/fsck/metawalk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index f2cd938..a4d7d3e 100644
--- a/gfs2/fsck/metawalk.c
+++ b/gfs2/fsck/metawalk.c
@@ -930,7 +930,7 @@ static int delete_block_if_notdup(struct gfs2_inode *ip, uint64_t block,
 	uint8_t q;
 	struct duptree *d;
 
-	if (!valid_block(ip->i_sbd, block) != 0)
+	if (!valid_block(ip->i_sbd, block))
 		return -EFAULT;
 
 	q = block_type(block);


More information about the cluster-commits mailing list