cluster: RHEL56 - GFS2 mount fails incorrectly after correctly failed second-mount attempt

Bob Peterson rpeterso at fedoraproject.org
Thu Sep 23 13:35:26 UTC 2010


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=6a3d7a53e4c9ca2e06e8c6043db86c08eba4d481
Commit:        6a3d7a53e4c9ca2e06e8c6043db86c08eba4d481
Parent:        ab8fc1a2100c81e7417bc15496cf293dde6512cd
Author:        Bob Peterson <rpeterso at redhat.com>
AuthorDate:    Thu Sep 23 08:21:45 2010 -0500
Committer:     Bob Peterson <rpeterso at redhat.com>
CommitterDate: Thu Sep 23 08:21:45 2010 -0500

GFS2 mount fails incorrectly after correctly failed second-mount attempt

When a user attempts to mount a GFS2 file system to a second mount
point, gfs_controld was not properly storing the id of the second
mount point in its mount point information.  If the mount attempt
fails, (for example, due to mount options incompatible with the
original mount), the mount point information was not being deleted
properly because of the missing id.  That caused subsequent mount
attempts to fail.  This patch stores the ID in the mount point
information so that it can be found later and removed properly for
failed mounts.

rhbz#559735
---
 group/gfs_controld/recover.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/group/gfs_controld/recover.c b/group/gfs_controld/recover.c
index 597516c..b33b3fd 100644
--- a/group/gfs_controld/recover.c
+++ b/group/gfs_controld/recover.c
@@ -1559,6 +1559,7 @@ int add_another_mountpoint(struct mountgroup *mg, char *dir, char *dev, int ci)
 	memset(mp, 0, sizeof(struct mountpoint));
 	strncpy(mp->dir, dir, sizeof(mp->dir));
 	list_add(&mp->list, &mg->mountpoints);
+	mp->client = ci;
 	mg->mount_client = ci;
 
 	/* we return this special error to mount.gfs which mount.gfs will


More information about the cluster-commits mailing list