gfs2-utils: master - gfs2_edit: Fix bitmap editing function
Steven Whitehouse
swhiteho at fedoraproject.org
Wed Oct 27 10:11:07 UTC 2010
Gitweb: http://git.fedorahosted.org/git/gfs2-utils.git?p=gfs2-utils.git;a=commitdiff;h=97368b361627c1a89f7e241297541118018504c9
Commit: 97368b361627c1a89f7e241297541118018504c9
Parent: b66405cf2d585f6de5f07d59aeba136af9db68d1
Author: Steven Whitehouse <swhiteho at redhat.com>
AuthorDate: Wed Oct 27 10:47:34 2010 +0100
Committer: Steven Whitehouse <swhiteho at redhat.com>
CommitterDate: Wed Oct 27 10:47:34 2010 +0100
gfs2_edit: Fix bitmap editing function
The bitmap editing function wasn't reading in the rgrp, so that it
would fail with a NULL pointer dereference.
Signed-off-by: Steven Whitehouse <swhiteho at redhat.com>
Cc: Bob Peterson <rpeterso at redhat.com>
---
gfs2/edit/hexedit.c | 28 ++++++++++++++--------------
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/gfs2/edit/hexedit.c b/gfs2/edit/hexedit.c
index c1c7512..80cbd26 100644
--- a/gfs2/edit/hexedit.c
+++ b/gfs2/edit/hexedit.c
@@ -2564,23 +2564,23 @@ static void find_change_block_alloc(int *newval)
if (ablock == sbd.sb_addr)
printf("3 (the superblock is not in the bitmap)\n");
else {
- if (newval) {
- if (gfs2_set_bitmap(&sbd, ablock, *newval))
- printf("-1 (block invalid or part of an rgrp).\n");
- else
- printf("%d\n", *newval);
- } else {
- rgd = gfs2_blk2rgrpd(&sbd, ablock);
- if (rgd) {
- gfs2_rgrp_read(&sbd, rgd);
+ rgd = gfs2_blk2rgrpd(&sbd, ablock);
+ if (rgd) {
+ gfs2_rgrp_read(&sbd, rgd);
+ if (newval) {
+ if (gfs2_set_bitmap(&sbd, ablock, *newval))
+ printf("-1 (block invalid or part of an rgrp).\n");
+ else
+ printf("%d\n", *newval);
+ } else {
type = gfs2_get_bitmap(&sbd, ablock, rgd);
- gfs2_rgrp_relse(rgd);
printf("%d (%s)\n", type, allocdesc[gfs1][type]);
- } else {
- gfs2_rgrp_free(&sbd.rglist);
- printf("-1 (block invalid or part of an rgrp).\n");
- exit(-1);
}
+ gfs2_rgrp_relse(rgd);
+ } else {
+ gfs2_rgrp_free(&sbd.rglist);
+ printf("-1 (block invalid or part of an rgrp).\n");
+ exit(-1);
}
}
gfs2_rgrp_free(&sbd.rglist);
More information about the cluster-commits
mailing list