gfs2-utils: master - gfs2_edit restoremeta should not return 0 on failure

Bob Peterson rpeterso at fedoraproject.org
Mon Jun 28 21:39:58 UTC 2010


Gitweb:        http://git.fedorahosted.org/git/gfs2-utils.git?p=gfs2-utils.git;a=commitdiff;h=5395532f6ba4b69218f35e9624609b9c44e733ed
Commit:        5395532f6ba4b69218f35e9624609b9c44e733ed
Parent:        3b88306556547f881df33a99858ef3d26d616b43
Author:        Bob Peterson <rpeterso at redhat.com>
AuthorDate:    Mon Jun 28 16:23:58 2010 -0500
Committer:     Bob Peterson <rpeterso at redhat.com>
CommitterDate: Mon Jun 28 16:38:25 2010 -0500

gfs2_edit restoremeta should not return 0 on failure

The gfs2_edit "restoremeta" function was always returning zero,
even when the restore was not successful.  This made it difficult
to automate some gfs2 testing.  This patch makes gfs2_edit return
the correct result from restoremeta.

rhbz#607321
---
 gfs2/edit/savemeta.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gfs2/edit/savemeta.c b/gfs2/edit/savemeta.c
index 7af9e48..23c9fdc 100644
--- a/gfs2/edit/savemeta.c
+++ b/gfs2/edit/savemeta.c
@@ -911,5 +911,5 @@ void restoremeta(const char *in_fn, const char *out_device,
 	if (!printblocksonly)
 		close(sbd.device_fd);
 
-	exit(0);
+	exit(error);
 }


More information about the cluster-commits mailing list