resource-agents: master - resource-agents: Clear vm.sh default

Fabio M. Di Nitto fabbione at fedoraproject.org
Tue Jul 6 03:50:45 UTC 2010


Gitweb:        http://git.fedorahosted.org/git/resource-agents.git?p=resource-agents.git;a=commitdiff;h=0c2fba3fc8c100a3aaf32e383a8954ae87916e06
Commit:        0c2fba3fc8c100a3aaf32e383a8954ae87916e06
Parent:        3e0c47b36f6f8e7cf3e590490213e907055669c3
Author:        Lon Hohberger <lhh at redhat.com>
AuthorDate:    Mon Mar 1 16:17:17 2010 -0500
Committer:     Fabio M. Di Nitto <fdinitto at redhat.com>
CommitterDate: Tue Jul 6 05:38:30 2010 +0200

resource-agents: Clear vm.sh default

The default behavior of vm.sh is to use_virsh whenever
possible.  The problem with specifying a default in the
RA metadata is that it causes rgmanager to provide a
value to the RA when it is called.  In this case, rgmanager
was providing "1" as the default, meaning that the logic
which carefully determines whether to use 'xm' or 'virsh'
is disabled.

This is not seen when testing the resource agent by
hand; it is only seen when called in the context of
rgmanager or rg_test.

Signed-off-by: Lon Hohberger <lhh at redhat.com>
---
 rgmanager/src/resources/vm.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rgmanager/src/resources/vm.sh b/rgmanager/src/resources/vm.sh
index 3ec8b87..09f3f6e 100644
--- a/rgmanager/src/resources/vm.sh
+++ b/rgmanager/src/resources/vm.sh
@@ -128,7 +128,7 @@ meta_data()
 		virtual machines instead of xm.  This is required when
 		using non-Xen virtual machines (e.g. qemu / KVM).
 	    </shortdesc>
-            <content type="integer" default="1"/>
+            <content type="integer" default=""/>
         </parameter>
 
 	<parameter name="xmlfile">


More information about the cluster-commits mailing list