cluster: RHEL48 - rgmanager: Fix stop/start race

Lon Hohberger lon at fedoraproject.org
Mon Jan 18 21:20:26 UTC 2010


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=928731d10c132abcc1f5567b3fbe2bbce23fd67e
Commit:        928731d10c132abcc1f5567b3fbe2bbce23fd67e
Parent:        e220cb0b3cef6279904967daabcbba6e3238d83f
Author:        Lon Hohberger <lhh at redhat.com>
AuthorDate:    Mon Jun 15 14:18:36 2009 -0400
Committer:     Lon Hohberger <lhh at redhat.com>
CommitterDate: Mon Jan 18 16:16:46 2010 -0500

rgmanager: Fix stop/start race

If a thread exits right as rgmanager gets a request
to start a new thread, there's a chance that the
the starting thread will incorrectly have a reference
to the old thread and not retry, causing an infinite
loop.

Resolves: rhbz#502872 rhbz#555925

Signed-off-by: Lon Hohberger <lhh at redhat.com>
---
 rgmanager/src/daemons/rg_thread.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/rgmanager/src/daemons/rg_thread.c b/rgmanager/src/daemons/rg_thread.c
index e96982b..c1d6140 100644
--- a/rgmanager/src/daemons/rg_thread.c
+++ b/rgmanager/src/daemons/rg_thread.c
@@ -500,6 +500,7 @@ spawn_if_needed(const char *resgroupname)
 	resthread_t *resgroup = NULL;
 
 retry:
+	resgroup = NULL;
 	pthread_mutex_lock(&reslist_mutex);
 	while (resgroup == NULL) {
 		resgroup = find_resthread_byname(resgroupname);


More information about the cluster-commits mailing list