cluster: RHEL56 - libgfs2: Remove unneeded sdp parameter in gfs2_block_set

Bob Peterson rpeterso at fedoraproject.org
Sat Apr 10 04:52:57 UTC 2010


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=10d21248358791b837772aabe06a524a01381356
Commit:        10d21248358791b837772aabe06a524a01381356
Parent:        4284f2110fc813cb30d3611d16728d4640aed6f3
Author:        Bob Peterson <bob at ganesha.peterson>
AuthorDate:    Thu Jan 21 17:07:41 2010 -0600
Committer:     Bob Peterson <rpeterso at redhat.com>
CommitterDate: Fri Apr 9 23:33:16 2010 -0500

libgfs2: Remove unneeded sdp parameter in gfs2_block_set

Function gfs2_blockmap_set does not use the sdp parameter, so
it only was wasting time passing it.  Therefore I removed it.
Again, this may not seem like much, but it's called for every
allocated block, which numbers in the millions.

rhbz#455300
---
 gfs2/fsck/pass1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gfs2/fsck/pass1.c b/gfs2/fsck/pass1.c
index 494cac5..804522a 100644
--- a/gfs2/fsck/pass1.c
+++ b/gfs2/fsck/pass1.c
@@ -738,7 +738,7 @@ static int handle_di(struct gfs2_sbd *sdp, struct gfs2_buffer_head *bh,
 				 compute_height(sdp, ip->i_di.di_size));
 			/* once implemented, remove continue statement */
 		log_warn( _("Marking inode invalid\n"));
-		if(gfs2_blockmap_set(sdp, bl, block, gfs2_meta_inval)) {
+		if(gfs2_blockmap_set(bl, block, gfs2_meta_inval)) {
 			stack;
 			fsck_inode_put(&ip);
 			return -1;


More information about the cluster-commits mailing list