code removal

Miroslav Suchý msuchy at redhat.com
Wed Jun 29 13:58:09 UTC 2011


I'm ranting in:
https://bugzilla.redhat.com/show_bug.cgi?id=656968
about duplicate code in subscription-manager. To be constructive I'm
sending you few patches.
And when I used that pylint I removed few dead lines of code.
See attachments.
-- 
Miroslav Suchy
Red Hat Satellite Engineering
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-there-is-no-need-to-override-method-if-there-is-noth.patch
Type: text/x-patch
Size: 840 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-move-get_dbus_iface-from-subscription_manager.gui.ut.patch
Type: text/x-patch
Size: 4234 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-reuse-code-already-defined-in-subscription_manager.u.patch
Type: text/x-patch
Size: 1491 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-do-not-print-anything-in-case-ancestor-does-not-over.patch
Type: text/x-patch
Size: 971 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-there-is-no-need-to-override-method-if-there-is-noth.patch
Type: text/x-patch
Size: 849 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-there-is-no-need-to-override-method-if-there-is-noth.patch
Type: text/x-patch
Size: 873 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-W-45-Unused-import-ImportSubDialog.patch
Type: text/x-patch
Size: 1014 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-W-37-Unused-import-activate.patch
Type: text/x-patch
Size: 1002 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-W-28-Unused-import-file_monitor.patch
Type: text/x-patch
Size: 930 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-W-42-Unused-import-AllSubscriptionsTab.patch
Type: text/x-patch
Size: 1086 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-W-47-Unused-import-datetime.patch
Type: text/x-patch
Size: 914 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-W-29-Unused-import-connection.patch
Type: text/x-patch
Size: 923 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-W-33-Unused-import-CertSorter.patch
Type: text/x-patch
Size: 1022 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-W-41-Unused-import-MySubscriptionsTab.patch
Type: text/x-patch
Size: 1075 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-W-33-Unused-import-CertLib.patch
Type: text/x-patch
Size: 998 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-W-40-Unused-import-InstalledProductsTab.patch
Type: text/x-patch
Size: 1012 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-W-39-Unused-import-widgets.patch
Type: text/x-patch
Size: 1009 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0018-W-33-Unused-import-find_first_invalid_date.patch
Type: text/x-patch
Size: 1117 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0019-W-25-Unused-import-messageWindow.patch
Type: text/x-patch
Size: 828 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0020-W-26-Unused-import-networkConfig.patch
Type: text/x-patch
Size: 820 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0021-W-43-Unused-import-SubscriptionAssistant.patch
Type: text/x-patch
Size: 996 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0022-W-38-Unused-import-factsgui.patch
Type: text/x-patch
Size: 951 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0021.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0023-W-33-Unused-import-EntitlementDirectory.patch
Type: text/x-patch
Size: 1095 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0022.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0024-W-33-Unused-import-ProductDirectory.patch
Type: text/x-patch
Size: 1051 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0023.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0025-W-32-Unused-import-Facts.patch
Type: text/x-patch
Size: 893 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0024.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0026-W-67-Unnecessary-semicolon.patch
Type: text/x-patch
Size: 869 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0025.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0027-W-26-Unused-import-ActionLock.patch
Type: text/x-patch
Size: 828 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0026.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0028-W-50-Unused-import-errorWindow.patch
Type: text/x-patch
Size: 1019 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0027.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0029-W-21-Unused-import-socket.patch
Type: text/x-patch
Size: 654 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0028.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0030-remove-wildcard-import.patch
Type: text/x-patch
Size: 1931 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0029.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0031-W-22-Unused-import-ActionLock.patch
Type: text/x-patch
Size: 819 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0030.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0032-W-85-Reimport-sys-imported-line-19.patch
Type: text/x-patch
Size: 746 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0031.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0033-W-55-configure_i18n-Reimport-gettext-imported-line-3.patch
Type: text/x-patch
Size: 832 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0032.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0034-reuse-systemExit-code.patch
Type: text/x-patch
Size: 813 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/candlepin/attachments/20110629/9c0ae4bf/attachment-0033.bin>


More information about the candlepin mailing list