Reviewing the customer create path

Jesus Rodriguez jesusr at redhat.com
Fri Mar 26 20:19:51 UTC 2010


On Fri, Mar 26, 2010 at 03:07:42PM -0400, Bryan Kearney wrote:
> I took my own advice.. And reviewed one of the existing stories. I have 
> a bunch of comments below.
> 
> Reviewing the Create Consumer Code
> ==================================
> 
> ConsumerResource
> ----------------
> - I assume the owner creation code in the ctor should be a fixme.

+1

> - Should the Identity cert creation go into the Curator? This seems like 
> business logic.

Probably not, I just reworked the create method, but I still left it
mostly intact. I could probably use even more cleanup like you mention.

> - In general, many of these classes actually implement business logic 
> (much of the bind logic). Should this move into a lower level business 
> curator? Perhaps there are other interim curators like the entitler. 
> Although the binder is probably a bad name :)

+1 to binder

> - Any reason to not rip out the commented out code blocks for the old 
> methods?

like I said in a previous response, I ripped these out.

jesus

-- 
jesus m. rodriguez          | jesusr at redhat.com
principal software engineer | irc: zeus
red hat systems management  | 919.754.4413 (w)
rhce # 805008586930012      | 919.623.0080 (c)
+---------------------------------------------+
|   "Those who cannot remember the past       |
|    are condemned to repeat it."             |
|                        -- George Santayana  |
+---------------------------------------------+




More information about the candlepin mailing list