I Assume this needs a big ole fixme

Bryan Kearney bkearney at redhat.com
Fri Mar 26 18:52:48 UTC 2010


On 03/26/2010 02:49 PM, Justin Harris wrote:
>
> ----- "Bryan Kearney"<bkearney at redhat.com>  wrote:
>
>> This is in the ctor of the consumer resource.
>>
>>
>>           if (username != null) {
>>               this.owner = ownerCurator.lookupByName(username);
>>               if (owner == null) {
>>                   owner = ownerCurator.create(new Owner(username));
>>               }
>>           }
>>
>> I assume this should be FIXME?
>
> I think that if the resource is a singleton then this is quite a problem...


Even if not :) Why create a new owner for a username?

-- bk



More information about the candlepin mailing list