[PATCH v3 0/7] Process synchronisation routines

Hubert Kario hkario at redhat.com
Thu Nov 21 16:57:08 UTC 2013


Hi all,

More or less final version, full functionality together with
test suite.

I haven't tested on RHEL 3 as the test harness doesn't work:

./test.sh: line 82: conditional binary operator expected
./test.sh: line 82: syntax error near `=~'
./test.sh: line 82: `    if [[ "$status" =~ ^$expected$ ]]; then'

RHEL 4 and RHEL5 (!) isn't much better:

  File "/root/beakerlib/src/test/../python/journalling.py", line 351
    with open("/etc/redhat-release", "r") as release_file:
            ^
SyntaxError: invalid syntax
rlJournalStart: Failed to initialize the journal. Bailing out...

I verified the library using the automated test suite on Fedora 19,
RHEL 6 and RHEL 7. I also manually checked if it works correctly
on RHEL 5 by copying it to /plugins and running few simple tests
the usual way. And, as I've mentioned in comments and previously,
it /should/ work on RHEL3 and later, trivial errors not
withstanding.

Regards,
Hubert

Hubert Kario (7):
  new routines for socket based synchronisation
  add synchronisation to system library
  use internal killtree, to not leave running sleep commands behind
  add rlWaitForCmd
  change rlWaitForSocket to use shared code
  add rlWaitForFile
  add tests for all synchronisation routines

 src/Makefile                    |   1 +
 src/beakerlib.sh                |   1 +
 src/synchronisation.sh          | 463 ++++++++++++++++++++++++++++++++++++++++
 src/test/synchronisationTest.sh | 238 +++++++++++++++++++++
 4 files changed, 703 insertions(+)
 create mode 100644 src/synchronisation.sh
 create mode 100644 src/test/synchronisationTest.sh

-- 
1.8.3.1



More information about the beakerlib-devel mailing list