[Beaker-devel] [RFC V3 PATCH 0/5] beaker harness support for autotest

Lucas Meneghel Rodrigues lmr at redhat.com
Fri Apr 12 20:06:21 UTC 2013


On Fri, 2013-04-12 at 15:09 -0400, Don Zickus wrote:
> Hi Folks,

FYI,

I've transformed your patchset into a github pull request, so you see
how one looks. Of course, I'll comment on the emails themselves in case
we find problems with it, so don't worry about getting out of the loop,
OK?

https://github.com/autotest/autotest/pull/629

Cheers,

Lucas

> Throwing this over the wall for a new round of reviewing.
> 
> Recently a bunch of autotest and beaker folks have been discussing how to get
> an autotest client working under beaker (namely Nick, Dan, Bill from beaker and
> Lucas, Cleber, Ademar from autotest).
> 
> A long time ago Jan Stancek whipped up some code to do that based on some
> discussions we both had.  I later modified a bunch of his code and came up with
> these patches.
> 
> I lasted touched these patches back in August 2012.  I never finished polishing
> them off or completed my testing due to other Red Hat obligations.
> 
> I am presenting these patches as a starting point for discussions as to how Jan
> and myself solved various problems.  They are very much 'beta' patches (there
> has been a lot of testing so they were stable at one point).
> 
> Unfortunately, I don't remember how all the pieces worked so instead of
> breaking the files into digestable chunks, I am just submitting whole files as
> new (well the first patch is a 'patch').
> 
> Please be kind.  I am cross-posting to various mailing lists to let anyone
> interested participate.
> 
> The end goal is to have autotest client work with the beaker server smoothly.
> This would allow various autotest projects to leverage the
> provisioning/inventorying mechanisms provided by beaker for various labs.
> 
> Feel free to direct all questions to me and I will do my best to remember what
> Jan and myself did.
> 
> I started running our internal kernel testsuite to get more live coverage of these
> changes.  Things work for the most part.  Reboot still has a bunch of issues,
> namely the 'autotest --continue' needs work done. :-(
> 
> I add some initial support to handle legacy beaker commands to talk with the 
> server.  I expect to simplify it later.
> 
> v2:  re-coded to use beaker's new stable API
>      thinned things out, added support for debug env
>      more testing
>      cleaned up coding style and syntax based on Lucas's feedback
> 
> v3: cleanup based on Lucas's feedback
>     reworked file uploading to deal with reboot state
>     little fixes from more testing
> 
> Don Zickus (4):
>   cmdparser:  add new command bootstrap
>   harness: support for beaker's xml
>   harness: support beaker proxy protocol
>   harness:  new beaker harness
> 
>  client/autotest_local.py |    2 +-
>  client/bkr_proxy.py      |  418 +++++++++++++++++++++++++++++++++++++++++
>  client/bkr_xml.py        |  145 +++++++++++++++
>  client/cmdparser.py      |   77 +++++++-
>  client/harness_beaker.py |  463 ++++++++++++++++++++++++++++++++++++++++++++++
>  client/shared/error.py   |    4 +
>  6 files changed, 1098 insertions(+), 11 deletions(-)
>  create mode 100644 client/bkr_proxy.py
>  create mode 100644 client/bkr_xml.py
>  create mode 100644 client/harness_beaker.py
> 
> Don Zickus (5):
>   cmdparser:  add new command bootstrap
>   harness: support for beaker's xml
>   harness: support beaker proxy protocol
>   harness:  new beaker harness
>   Harness: Add beaker hook for quick commands
> 
>  client/autotest_local.py  |    2 +-
>  client/bkr_proxy.py       |  409 +++++++++++++++++++++++++++++++
>  client/bkr_xml.py         |  145 +++++++++++
>  client/cmdparser.py       |   90 ++++++-
>  client/harness_beaker.py  |  587 +++++++++++++++++++++++++++++++++++++++++++++
>  client/rhts-reboot        |    4 +
>  client/rhts-report-result |    7 +
>  client/rhts-submit-log    |    6 +
>  client/rhts_submit_log    |    6 +
>  client/shared/error.py    |    4 +
>  10 files changed, 1249 insertions(+), 11 deletions(-)
>  create mode 100644 client/bkr_proxy.py
>  create mode 100644 client/bkr_xml.py
>  create mode 100644 client/harness_beaker.py
>  create mode 100755 client/rhts-reboot
>  create mode 100755 client/rhts-report-result
>  create mode 100755 client/rhts-submit-log
>  create mode 100755 client/rhts_submit_log
> 




More information about the Beaker-devel mailing list