<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Looks ok to me.<br>
    <br>
    <div class="moz-cite-prefix">On 12/03/2014 03:59 AM, Colin Walters
      wrote:<br>
    </div>
    <blockquote
cite="mid:1417575552.2590077.198122661.461C35BA@webmail.messagingengine.com"
      type="cite">
      <pre wrap="">shutil.copytree() follows symlinks by default which I didn't realize,
and this actively breaks things as grubenv is a symlink.

Since we're shelling out to 'cp' in a case above, might as well do it
here.

This also means that if we hit e.g. ENOSPC we'll enter the error
handling codepath instead of an uncaught traceback.

(Yes, this code is crappy, should probably live in bootloader.py,
 except I'm going through gyrations here to avoid requiring
 any changes in how mainline bootloaders work)
---
 pyanaconda/packaging/rpmostreepayload.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pyanaconda/packaging/rpmostreepayload.py b/pyanaconda/packaging/rpmostreepayload.py
index ade664c..f96a316 100644
--- a/pyanaconda/packaging/rpmostreepayload.py
+++ b/pyanaconda/packaging/rpmostreepayload.py
@@ -119,7 +119,7 @@ class RPMOSTreePayload(ArchivePayload):
                     self._safeExecWithRedirect('cp', ['-r', '-p', sub_srcpath, sub_destpath])
             else:
                 log.info("Copying bootloader data: " + fname)
-                shutil.copytree(srcpath, destpath)
+                self._safeExecWithRedirect('cp', ['-r', '-p', srcpath, destpath])
 
     def install(self):
         mainctx = GLib.MainContext.new()
</pre>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
anaconda-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:anaconda-patches@lists.fedorahosted.org">anaconda-patches@lists.fedorahosted.org</a>
<a class="moz-txt-link-freetext" href="https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches">https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>