[master 1/1] Do not override StorageChecker.errors in StorageSpoke (#1252596)

clumens installerbot-noreply at redhat.com
Wed Sep 30 19:40:20 UTC 2015


In reply to line 1041 of pyanaconda/ui/gui/spokes/storage.py:

This block, and the block under self.errors are very similar and just begging to be converted into a function.  This will especially help should we need to add additional quit behavior.

Updating for previous discussion above.  I see three differences:  (1) if self.errors vs. if self.disk_errors - Just have this live outside of any function.  (2) Different label - that's one argument.  (3) Different label on one button - that's a second argument.

-- 
To view this comment on github, visit https://github.com/vojtechtrefny/anaconda/commit/53bfc00d43f7be0c966705b9cef346a37817ed99#commitcomment-13526314


More information about the anaconda-patches mailing list