[rhinstaller/anaconda/pulls/376 master] Do not override StorageChecker.errors in StorageSpoke (#1252596)
jkonecny12
installerbot-noreply at redhat.com
Wed Sep 30 08:21:41 UTC 2015
> @@ -1014,7 +1015,28 @@ def on_specialized_clicked(self, button):
> NormalSpoke.on_back_clicked(self, button)
>
> def on_info_bar_clicked(self, *args):
> - if self.errors:
> + if self.disks_errors:
> + label = _("The following errors were encountered when checking your disk "
> + "selection. You can modify your selection or quit the "
> + "installer.")
> +
> + dialog = DetailedErrorDialog(self.data, buttons=[
> + C_("GUI|Storage|Error Dialog", "_Quit"),
> + C_("GUI|Storage|Error Dialog", "_Modify Disk Selection")],
> + label=label)
> + with self.main_window.enlightbox(dialog.window):
> + errors = "\n".join(self.disks_errors)
> + dialog.refresh(errors)
> + rc = dialog.run()
> +
> + dialog.window.destroy()
> +
> + if rc == 0:
> + # Quit.
> + iutil.ipmi_report(constants.IPMI_ABORTED)
> + sys.exit(0)
Yeah right, sorry I missed this differences before.
Looks good to me (now when I'm not so blind :) ), I'm returning the Ack now.
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/376#discussion_r40768763
More information about the anaconda-patches
mailing list