[rhinstaller/blivet/pulls/235 master] Add umount next to unmount method to avoid miscall

vpodzime installerbot-noreply at redhat.com
Thu Sep 24 11:37:15 UTC 2015


> @@ -765,6 +765,18 @@ def unmount(self, **kwargs):
>          """
>          return self.teardown(**kwargs)
>  
> +    def umount(self, **kwargs):
> +        """ Unmount this filesystem.
> +
> +            :param str mountpoint: Optional mountpoint to be unmounted.

While doing this, could you please replace ``param`` with ``keyword`` here as well as in the ``unmount()`` method? That's the proper field name, I think.

-- 
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/235#discussion_r40309319


More information about the anaconda-patches mailing list