[rhel7-branch] Update storage config after running dasdfmt. (#1264411)

Samantha N. Bueno sbueno+anaconda at redhat.com
Wed Sep 23 13:39:25 UTC 2015


On Wed, Sep 23, 2015 at 10:36:44AM +0200, Vratislav Podzimek wrote:
> On Tue, 2015-09-22 at 15:06 -0400, Samantha N. Bueno wrote:
> > [I feel like this was fixed before, but I think it was something else
> > that I had to rip out later since it caused problems.
> > Anyway.]
> Wasn't it the call of the execute() method?

Yeah, what a disaster. Unfortunately I neglected to realize that the
storage config still needed to be updated to reflect disk changes, hence
this.
 
> > diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py
> > index ca5d30b..155fe7e 100644
> > --- a/pyanaconda/ui/gui/spokes/storage.py
> > +++ b/pyanaconda/ui/gui/spokes/storage.py
> > @@ -314,6 +314,7 @@ class StorageSpoke(NormalSpoke, StorageChecker):
> >          hubQ.send_not_ready(self.__class__.__name__)
> >          # on the off-chance dasdfmt is running, we can't proceed further
> >          threadMgr.wait(constants.THREAD_DASDFMT)
> > +        threadMgr.wait(constants.THREAD_STORAGE)
> >          hubQ.send_message(self.__class__.__name__, _("Saving storage configuration..."))
> I think the wait should go after the status is changed because otherwise
> users will see something like "No disks selected" while we are waiting
> for the thread and then the "Saving storage configuration" status will
> show for a hardly-noticeable moment.

Sure, that makes sense.
 
> Looks good to me otherwise.

Thanks.
 
> -- 
> Vratislav Podzimek
> 
> Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list