[PATCH 1/5] Move kickstart_test .ks files to .ks.in.

David Shea dshea at redhat.com
Mon Sep 14 19:25:51 UTC 2015


On 09/14/2015 10:42 AM, Chris Lumens wrote:
>> The changes look good to me, I'm just more and more afraid of the
>> growing amount of cryptic bash stuff we have in these directories.
> I don't disagree on the amount of shell magic.  I just can't think of a
> better way to do it.  I considered using makefile substitution magic,
> but I decided that having to use autoconf for that plus still having to
> get the values in from somewhere.
>
> If anyone knows a cleaner way, I'd love to hear it.

For what it's worth, I think that using autoconf to try to do the 
substitutions would be a step backwards, since you can't use wildcards 
in that list of files to substitute on. And Makefile % wildcards just 
seem to cause trouble.


More information about the anaconda-patches mailing list