[rhel7-branch][PATCH] Try to deal with expected errors from devicetree.populate (#1257648)

Brian C. Lane bcl at redhat.com
Wed Sep 9 18:13:30 UTC 2015


On Wed, Sep 09, 2015 at 10:34:57AM +0200, Vratislav Podzimek wrote:
> If we call blivet.storageInitialize(), Blivet tries to run our error handler for
> errors because some of them can be resolved by user (like duplicate VG names)
> and many others should at least be reported in a nice way not by showing the
> exception handler's dialog. We should do the same whenever we call
> devicetree.populate() because many such errors can appear at that phase (like
> iSCSI device with a duplicate VG name added or LUKS device opened, etc.).
> 
> Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> ---
>  pyanaconda/rescue.py                         |  3 ++-
>  pyanaconda/storage_utils.py                  | 26 ++++++++++++++++++++++++++
>  pyanaconda/ui/gui/spokes/advstorage/dasd.py  |  3 ++-
>  pyanaconda/ui/gui/spokes/advstorage/fcoe.py  |  3 ++-
>  pyanaconda/ui/gui/spokes/advstorage/iscsi.py |  3 ++-
>  pyanaconda/ui/gui/spokes/advstorage/zfcp.py  |  3 ++-
>  pyanaconda/ui/gui/spokes/custom.py           |  3 ++-
>  pyanaconda/ui/gui/spokes/filter.py           |  3 ++-
>  8 files changed, 40 insertions(+), 7 deletions(-)

Ack. I like that.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list