[PATCH] Remove a call to execute in storage thread to avoid a threading disaster. (#1245268)

Samantha N. Bueno sbueno+anaconda at redhat.com
Wed Sep 2 16:02:39 UTC 2015


I forgot to mention this is for anaconda on every branch, sorry.

On Wed, Sep 02, 2015 at 12:00:54PM -0400, Samantha N. Bueno wrote:
> When I first introduced this dasdfmt code, I issued a manual call to
> execute() in the storage threada after running dasdfmt to re-jigger
> everything (detect newly-formatted DASDs etc). Turns out this is not
> necessary at all--if doing a ks install, dasdfmt is called _before_
> execute() is ever called anyway, so it only added a duplicate thread,
> causing anaconda to crash.
> 
> Tl;dr get rid of some unnecessary junk.
> 
> Resolves: rhbz1245268
> ---
>  pyanaconda/ui/gui/spokes/storage.py | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py
> index 25b27e6..fe2cd10 100644
> --- a/pyanaconda/ui/gui/spokes/storage.py
> +++ b/pyanaconda/ui/gui/spokes/storage.py
> @@ -696,10 +696,6 @@ class StorageSpoke(NormalSpoke, StorageChecker):
>                      log.error(str(err))
>                      continue
>  
> -        # I really hate doing this, but the way is the way; probably the most
> -        # correct way to kajigger the storage spoke into becoming ready
> -        self.execute()
> -
>      # signal handlers
>      def on_summary_clicked(self, button):
>          # show the selected disks dialog
> -- 
> 1.9.3
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list