[master 1/3] Don't be naïve about liblvm

vpodzime installerbot-noreply at redhat.com
Tue Sep 1 09:29:18 UTC 2015


From: Vratislav Podzimek <vpodzime at redhat.com>

It's not going to be a working/usable reality any time soon so stop pretending
the opposite as that's just confusing.
---
 blivet/devices/lvm.py   | 3 ---
 blivet/formats/lvmpv.py | 2 --
 2 files changed, 5 deletions(-)

diff --git a/blivet/devices/lvm.py b/blivet/devices/lvm.py
index 04ac753..8047aec 100644
--- a/blivet/devices/lvm.py
+++ b/blivet/devices/lvm.py
@@ -326,9 +326,6 @@ def _removeParent(self, member):
     # We can't rely on lvm to tell us about our size, free space, &c
     # since we could have modifications queued, unless the VG and all of
     # its PVs already exist.
-    #
-    #        -- liblvm may contain support for in-memory devices
-
     @property
     def isModified(self):
         """ Return True if the VG has changes queued that LVM is unaware of. """
diff --git a/blivet/formats/lvmpv.py b/blivet/formats/lvmpv.py
index c19221c..ee3e29e 100644
--- a/blivet/formats/lvmpv.py
+++ b/blivet/formats/lvmpv.py
@@ -78,8 +78,6 @@ def __init__(self, **kwargs):
         DeviceFormat.__init__(self, **kwargs)
         self.vgName = kwargs.get("vgName")
         self.vgUuid = kwargs.get("vgUuid")
-        # liblvm may be able to tell us this at some point, even
-        # for not-yet-created devices
         self.peStart = kwargs.get("peStart", lvm.LVM_PE_START)
         self.dataAlignment = kwargs.get("dataAlignment", Size(0))
 


-- 
To view this commit on github, visit https://github.com/rhinstaller/blivet/commit/07fff7ba0b22fb40319b8432700dbf4f93930704


More information about the anaconda-patches mailing list