[rhinstaller/anaconda/pulls/423 f23-branch] Improve install space required estimation (#1224048)

vpodzime installerbot-noreply at redhat.com
Mon Oct 26 08:44:20 UTC 2015


> @@ -555,11 +555,14 @@ def spaceRequired(self):
>              if key.startswith('/') and ((root_mpoint + new_key) not in valid_points):
>                  valid_points[root_mpoint + new_key] = val.format.freeSpaceEstimate(val.size)
>  
> -        m_points = _pick_mpoint(valid_points, download_size, size)
> -        if not m_points or m_points == root_mpoint:
> +        m_point = _pick_mpoint(valid_points, download_size, size)
> +        if not m_point or m_point == root_mpoint:
>              # download and install to the same mount point
>              size = size + download_size
> -        log.debug("Instalation space required %s for mpoints %s", size, m_points)
> +            log.debug("Install + download space required %s", size)
> +        else:
> +            log.debug("Download space required %s for mpoint %s (non-chroot)", download_size, m_point)

*non-root* would be more precise here, but then you see it's obvious from the mount point so I think it could be dropped

-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/423#discussion_r42969028


More information about the anaconda-patches mailing list