[firstboot][rhel6-branch][PATCH] Fix a ksh specific error in the s390 startup script (#1117749)

Chris Lumens clumens at redhat.com
Fri Oct 23 20:22:58 UTC 2015


> diff --git a/scripts/firstboot.sh b/scripts/firstboot.sh
> index 5b4ec9d..e8003f7 100644
> --- a/scripts/firstboot.sh
> +++ b/scripts/firstboot.sh
> @@ -7,7 +7,7 @@ FIRSTBOOT_CONF=/etc/sysconfig/firstboot
>  [ -f $FIRSTBOOT_CONF ] && . $FIRSTBOOT_CONF
>  
>  # check if we should run firstboot
> -if [ -f $FIRSTBOOT_EXEC ] && [ "${RUN_FIRSTBOOT,,}" = "yes" ]; then
> +if [ -f $FIRSTBOOT_EXEC ] && [ "${RUN_FIRSTBOOT}" = "yes" ]; then

This will subtly change things.  The point of the ${,,} thing is to
convert $RUN_FIRSTBOOT to lowercase to make sure it matches "yes".  If
you can guarantee that RUN_FIRSTBOOT will always be in lower case, this
patch is fine.  Otherwise, it'll potentially break things.

- Chris


More information about the anaconda-patches mailing list