[rhinstaller/anaconda/pulls/421 master] Improve password salt creation (#1229474)

vpodzime installerbot-noreply at redhat.com
Thu Oct 22 07:43:51 UTC 2015


> @@ -807,3 +808,12 @@ def open_with_perm_test(self):
>                  os.umask(old_umask)
>          finally:
>              shutil.rmtree(test_dir)
> +
> +class EncryptPasswordTests(unittest.TestCase):
> +    def encrypt_password_test(self):
> +        """ Test the encrypt_password function"""
> +        for algo in ["$1$", "$5$", "$6$"]:
> +            enc_pw = iutil.encrypt_password("DocBrown", algo, 16)
> +            self.assertEqual(algo, enc_pw[:3])
> +            self.assertEqual(crypt.crypt("DocBrown", enc_pw), enc_pw)
> +            self.assertNotEqual(crypt.crypt("Einstein", enc_pw), enc_pw)

Looking at this makes me wonder why we are not using ``crypt.crypt()`` instead of our custom code? Looks like it even got some improvements with Python 3 which were backported to 2.7.

-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/421#discussion_r42719171


More information about the anaconda-patches mailing list