[rhinstaller/anaconda/pulls/406 master] Use GtkResponseType values in the iso chooser dialog

dashea installerbot-noreply at redhat.com
Wed Oct 14 15:07:26 UTC 2015


> I think we should do this consistently in all places, not just a single one that is broken right now.

Unless glade decides to expose the GtkResponseType values, I don't think it will help. The iso file chooser is the only subclass of GtkDialog that anaconda uses, and for normal GtkDialogs there is no special meaning attached to any of the responses. The response IDs are always something we'll have to hardcode in glade and match in python, and I don't feel like having a "Yes" button return -8 instead of 1 is any better, especially since I had to grep through some header files to figure out that GTK_RESPONSE_YES is -8.
-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/406


More information about the anaconda-patches mailing list