[initial-setup][master/rhel7-branch][PATCH] Improve log messages for kickstart parsing error

Brian C. Lane bcl at redhat.com
Mon Oct 12 21:17:54 UTC 2015


On Mon, Oct 12, 2015 at 06:31:31PM +0200, Martin Kolman wrote:
> Log only the error message from the kickstart parsing error and
> also add a message clarifying that Initial Setup startup has failed
> due to invalid kickstart file.
> 
> Signed-off-by: Martin Kolman <mkolman at redhat.com>
> ---
>  initial_setup/__main__.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/initial_setup/__main__.py b/initial_setup/__main__.py
> index 7364b9a..1fbff51 100644
> --- a/initial_setup/__main__.py
> +++ b/initial_setup/__main__.py
> @@ -103,7 +103,8 @@ try:
>      parser.readKickstart(kickstart_path)
>      log.info("kickstart parsing done")
>  except pykickstart.errors.KickstartError as kserr:
> -    log.exception("kickstart parsing failed: %s" % kserr)
> +    log.critical("kickstart parsing failed: %s", kserr)
> +    log.critical("Initial Setup startup failed due to invalid kickstart file")
>      sys.exit(1)
>  
>  if external_reconfig:
> -- 
> 2.4.3

ack.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list