[master 2/3] Do not set the password input text with unencrypted passwords.

dashea installerbot-noreply at redhat.com
Wed Oct 7 13:51:48 UTC 2015


From: David Shea <dshea at redhat.com>

Even though the password is obscured with invisible_char, the
administrator providing the kickstart may not want the number of
characters in the kickstart password exposed to a user at the terminal.
---
 pyanaconda/ui/gui/spokes/user.py | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/user.py b/pyanaconda/ui/gui/spokes/user.py
index 9350976..6addc44 100644
--- a/pyanaconda/ui/gui/spokes/user.py
+++ b/pyanaconda/ui/gui/spokes/user.py
@@ -304,13 +304,8 @@ def initialize(self):
         # the Gtk signal handlers use the input check variables.
         if self._user.password_kickstarted:
             self.usepassword.set_active(self._user.password != "")
-            if not self._user.isCrypted:
-                self.pw.set_text(self._user.password)
-                self.confirm.set_text(self._user.password)
-            else:
-                self.usepassword.set_active(True)
-                self.pw.set_placeholder_text(_("The password was set by kickstart."))
-                self.confirm.set_placeholder_text(_("The password was set by kickstart."))
+            self.pw.set_placeholder_text(_("The password was set by kickstart."))
+            self.confirm.set_placeholder_text(_("The password was set by kickstart."))
         elif not self.policy.emptyok:
             # Policy is that a non-empty password is required
             self.usepassword.set_active(True)


-- 
To view this commit on github, visit https://github.com/rhinstaller/anaconda/commit/08e9608b6345a91619a964e21ef72549a2f573e6


More information about the anaconda-patches mailing list