[master 1/1] Include original kickstart in logs (#1227939)

Brian C. Lane bcl at redhat.com
Tue Nov 10 20:02:12 UTC 2015


On Tue, Nov 10, 2015 at 11:05:43AM -0800, Adam Williamson wrote:
> On Tue, 2015-11-10 at 18:30 +0000, bcl wrote:
> > From: "Brian C. Lane" <bcl at redhat.com>
> > 
> > Having the original un-modified kickstart can sometimes be useful,
> > include it in /var/log/anaconda/ks.cfg
> 
> Couldn't it sometimes include sensitive information (most
> obviously unhashed passwords, but also perhaps details of internal
> network configuration or similar)? As ks.cfg gets uploaded to BZ when
> reporting crashes, this could be a bad idea?

This copy only happens at the end of the installation, so it wouldn't
get sent to bz. But we also shouldn't really mix sanitized data with
un-sanitized data so re-wrote it to copy to /root/original-ks.cfg

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list